Skip to content

adjust setup.py for ROCm #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jeffdaily
Copy link

@naromero77amd
Copy link

@zou3519 Are you able to review?

@@ -30,7 +31,7 @@ def get_extensions():
if debug_mode:
print("Compiling in debug mode")

use_cuda = use_cuda and torch.cuda.is_available() and CUDA_HOME is not None
use_cuda = use_cuda and torch.cuda.is_available() and (CUDA_HOME is not None or ROCM_HOME is not None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I put up pytorch/pytorch#158032, what I meant by "we should test this" is more that we should add some CI tests for this. Is that possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extension-cpp claims ROCM support with no additional changes; we should test this.
4 participants